Skip to content

[Common] Compile headers#16993

Open
vkucera wants to merge 1 commit into
AliceO2Group:masterfrom
vkucera:clang-headers-Common
Open

[Common] Compile headers#16993
vkucera wants to merge 1 commit into
AliceO2Group:masterfrom
vkucera:clang-headers-Common

Conversation

@vkucera

@vkucera vkucera commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Provides missing compile commands needed by Clang-Tidy.

Provides missing compile commands needed by Clang-Tidy.
@github-actions github-actions Bot added the common label Jul 9, 2026
@github-actions github-actions Bot changed the title Compile headers [Common] Compile headers Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 23 errors, ⚠️ 34 warnings, 🔕 0 disabled

@vkucera vkucera marked this pull request as ready for review July 9, 2026 15:35
@alibuild

alibuild commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 86bfeb0 at 2026-07-09 18:01:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 32 errors and 15 warnings.'
Found 32 errors and 15 warnings.
++ [[ 32 -gt 0 ]]
++ cat /sw/BUILD/0587597533e4101bc1c3be0d259b4aae82b59eb7/O2Physics-code-check/errors.txt
Common/Tools/PID/pidTPCModule.h:55:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:57:1: error: nested namespaces can be concatenated [modernize-concat-nested-namespaces,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:96:82: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:97:76: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:102:94: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:174:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:183:28: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:220:15: error: redundant string initialization [readability-redundant-string-init,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:238:7: error: no header providing "LOGF" is directly included [misc-include-cleaner,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:266:13: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:270:17: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:283:15: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:308:45: error: the const qualified parameter 'particle' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:346:9: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:349:9: error: no header providing "LOGP" is directly included [misc-include-cleaner,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:357:11: error: no header providing "TString" is directly included [misc-include-cleaner,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:383:9: error: no header providing "LOG" is directly included [misc-include-cleaner,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:404:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:413:191: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:413:241: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:422:15: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:442:91: error: no header providing "o2::aod::EvSels" is directly included [misc-include-cleaner,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:452:13: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:488:189: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:488:239: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:518:11: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:526:9: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:774:13: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:782:11: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:812:16: error: variable 'hadronicRate' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:813:13: error: variable 'occupancy' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:877:13: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
++ [[ 15 -gt 0 ]]
++ cat /sw/BUILD/0587597533e4101bc1c3be0d259b4aae82b59eb7/O2Physics-code-check/warnings.txt
Common/Tools/PID/pidTPCModule.h:629:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:631:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:637:22: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:639:22: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:647:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:649:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:681:18: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:683:18: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants