Skip to content

[Trigger,PWGUD] DPL Analysis: use API instead of direct construction #16990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aalkin wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

[Trigger,PWGUD] DPL Analysis: use API instead of direct construction #16990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion EventFiltering/PWGUD/diffractionBCFilter.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@
}
PROCESS_SWITCH(tracksWGTInBCs, processBarrel, "Process barrel tracks", true);

void processForward(BCs& bcs, CCs& /*collisions*/, aod::FwdTracks& fwdTracks, aod::AmbiguousFwdTracks& ambFwdTracks)

Check failure on line 162 in EventFiltering/PWGUD/diffractionBCFilter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-process] 

Argument aod::AmbiguousFwdTracks& ambFwdTracks is not const&.

Check failure on line 162 in EventFiltering/PWGUD/diffractionBCFilter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-process] 

Argument aod::FwdTracks& fwdTracks is not const&.

Check failure on line 162 in EventFiltering/PWGUD/diffractionBCFilter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-process] 

Argument CCs& /*collisions*/ is not const&.

Check failure on line 162 in EventFiltering/PWGUD/diffractionBCFilter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-process] 

Argument BCs& bcs is not const&.
{
// run number
int rnum = bcs.iteratorAt(0).runNumber();
Expand Down Expand Up @@ -310,7 +310,7 @@
aod::Zdcs& /*zdcs*/,
aod::FT0s& /*ft0s*/,
aod::FV0As& /*fv0as*/,
aod::FDDs& /*fdds*/)

Check failure on line 313 in EventFiltering/PWGUD/diffractionBCFilter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-process] 

Argument aod::FV0As& /*fv0as*/ is not const&.

Check failure on line 313 in EventFiltering/PWGUD/diffractionBCFilter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-process] 

Argument aod::FT0s& /*ft0s*/ is not const&.

Check failure on line 313 in EventFiltering/PWGUD/diffractionBCFilter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-process] 

Argument aod::Zdcs& /*zdcs*/ is not const&.

Check failure on line 313 in EventFiltering/PWGUD/diffractionBCFilter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-process] 

Argument FWs& fwdtracks is not const&.

Check failure on line 313 in EventFiltering/PWGUD/diffractionBCFilter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-process] 

Argument TCs& /*tracks*/ is not const&.
{

// Advance these pointers step-by-step
Expand All @@ -321,7 +321,7 @@

// loop over bcs
int isDGBC;
for (auto bc : bcs) {

Check failure on line 324 in EventFiltering/PWGUD/diffractionBCFilter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
auto bcnum = bc.globalBC();
auto ccs = false;

Expand All @@ -348,7 +348,7 @@
auto fwdTracksArray = ftibc.fwdtrack_as<FTCs>();
isDGBC = dgSelector.IsSelected(diffCuts, bcRange, tracksArray, fwdTracksArray);
} else {
auto fwdTracksArray = FTCs{{fwdtracks.asArrowTable()->Slice(0, 0)}, (uint64_t)0};
auto fwdTracksArray = fwdtracks.emptySlice();
isDGBC = dgSelector.IsSelected(diffCuts, bcRange, tracksArray, fwdTracksArray);
}

Expand Down
Loading