Skip to content

[Tutorial] DPL Analysis: use API instead of direct construction #16989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aalkin wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

[Tutorial] DPL Analysis: use API instead of direct construction #16989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tutorials/src/compatibleBCs.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in Tutorials/src/compatibleBCs.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-process] 

Use constant references for table subscriptions in process functions.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand Down Expand Up @@ -60,7 +60,7 @@

LOGF(info, "Will consider BC entries from %d to %d", minBCId, maxBCId);

T slice{{bcs.asArrowTable()->Slice(minBCId, maxBCId - minBCId + 1)}, (uint64_t)minBCId};
auto slice = bcs.rawSlice(minBCId, maxBCId);
bcs.copyIndexBindings(slice);
return slice;
}
Expand All @@ -74,7 +74,7 @@

auto bcSlice = getCompatibleBCs(collision, bcs);

for (auto& bc : bcSlice) {

Check failure on line 77 in Tutorials/src/compatibleBCs.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
LOGF(info, "This collision may belong to BC %lld", bc.globalBC());
}
}
Expand All @@ -86,7 +86,7 @@
// Note that one has to subscribe to aod::FT0s and aod::FV0As to load
// the relevant data even if you access the data itself through m.ft0() and m.fv0a()
struct CompatibleT0V0A {
void process(aod::Collision const& collision, soa::Join<aod::BCs, aod::Run3MatchedToBCSparse> const& bct0s, aod::FT0s& /*ft0s*/, aod::FV0As& /*fv0as*/)

Check failure on line 89 in Tutorials/src/compatibleBCs.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-process] 

Argument aod::FV0As& /*fv0as*/ is not const&.

Check failure on line 89 in Tutorials/src/compatibleBCs.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-process] 

Argument aod::FT0s& /*ft0s*/ is not const&.
{
// NOTE collision.bc() causes SEGV here because we have only subscribed to BCs joined, therefore:
auto bc = collision.bc_as<soa::Join<aod::BCs, aod::Run3MatchedToBCSparse>>();
Expand All @@ -94,7 +94,7 @@

auto bcSlice = getCompatibleBCs(collision, bct0s);

for (auto& bc : bcSlice) {

Check failure on line 97 in Tutorials/src/compatibleBCs.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if (bc.has_ft0() && bc.has_fv0a()) {
LOGF(info, "This collision may belong to BC %lld and has T0 timeA: %f and V0A time: %f", bc.globalBC(), bc.ft0().timeA(), bc.fv0a().time());
}
Expand Down
Loading