Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
9a2088b
readability-braces-around-statements
mcoquet642 Jul 7, 2026
46c53e2
cppcoreguidelines-init-variables
mcoquet642 Jul 7, 2026
78f5274
bugprone-narrowing-conversions
mcoquet642 Jul 7, 2026
2af2f29
performance-move-const-arg
mcoquet642 Jul 7, 2026
9cea446
readability-simplify-boolean-expr
mcoquet642 Jul 7, 2026
2c9b55c
bugprone-redundant-branch-condition
mcoquet642 Jul 7, 2026
d690fee
performance-unnecessary-copy-initialization
mcoquet642 Jul 7, 2026
8af78ae
cppcoreguidelines-pro-type-member-init
mcoquet642 Jul 7, 2026
70ecf92
readability-else-after-return
mcoquet642 Jul 7, 2026
83f768a
modernize-use-nullptr
mcoquet642 Jul 7, 2026
bd2802f
readability-container-contains
mcoquet642 Jul 7, 2026
b056846
readability-inconsistent-declaration-parameter-name
mcoquet642 Jul 7, 2026
341ee19
performance-unnecessary-value-param
mcoquet642 Jul 7, 2026
d1b2e1f
readability-redundant-access-specifiers
mcoquet642 Jul 7, 2026
96a674d
readability-enum-initial-value
mcoquet642 Jul 7, 2026
bbb5b4d
modernize-deprecated-headers
mcoquet642 Jul 7, 2026
6d07275
misc-include-cleaner
mcoquet642 Jul 7, 2026
e5843f5
some modernize-avoid-c-arrays
mcoquet642 Jul 7, 2026
91afd7d
clang format
mcoquet642 Jul 8, 2026
ca74ee7
missing std::
mcoquet642 Jul 8, 2026
59ea51a
use RecoDecay::constrainAngle
mcoquet642 Jul 8, 2026
f5ee49a
const refs and use pdg constants
mcoquet642 Jul 8, 2026
142c956
fixing Megalinter issues
mcoquet642 Jul 8, 2026
c3c44e4
using std::array
mcoquet642 Jul 8, 2026
d9b404c
Please consider the following formatting changes
alibuild Jul 8, 2026
3d1e9c7
Merge pull request #27 from alibuild/alibot-cleanup-16962
mcoquet642 Jul 8, 2026
dcbf1a4
format fix
mcoquet642 Jul 8, 2026
bd1e443
removing leftover else
mcoquet642 Jul 8, 2026
511d8f4
commenting unused variable
mcoquet642 Jul 8, 2026
436a078
haromic type unsigned int
mcoquet642 Jul 8, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PWGDQ/Core/VarManager.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
o2::vertexing::FwdDCAFitterN<3> VarManager::fgFitterThreeProngFwd;
o2::globaltracking::MatchGlobalFwd VarManager::mMatching;
std::map<VarManager::CalibObjects, TObject*> VarManager::fgCalibs;
bool VarManager::fgRunTPCPostCalibration[4] = {false, false, false, false};
std::array<bool, 4> VarManager::fgRunTPCPostCalibration = {false, false, false, false};
int VarManager::fgCalibrationType = 0; // 0 - no calibration, 1 - calibration vs (TPCncls,pIN,eta) typically for pp, 2 - calibration vs (eta,nPV,nLong,tLong) typically for PbPb
bool VarManager::fgUseInterpolatedCalibration = true; // use interpolated calibration histograms (default: true)
int VarManager::fgEfficiencyType = 0; // type of efficiency to be applied, default is no efficiency
Expand Down Expand Up @@ -191,8 +191,8 @@
// TO Do: add more systems

// set the beam 4-momentum vectors
float beamAEnergy = energy / 2.0 * sqrt(NumberOfProtonsA * NumberOfProtonsC / NumberOfProtonsC / NumberOfProtonsA); // GeV

Check failure on line 194 in PWGDQ/Core/VarManager.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix]

Use std:: prefix for names from the std namespace.
float beamCEnergy = energy / 2.0 * sqrt(NumberOfProtonsC * NumberOfProtonsA / NumberOfProtonsA / NumberOfProtonsC); // GeV

Check failure on line 195 in PWGDQ/Core/VarManager.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix]

Use std:: prefix for names from the std namespace.
float beamAMomentum = std::sqrt(beamAEnergy * beamAEnergy - NumberOfNucleonsA * NumberOfNucleonsA * MassProton * MassProton);
float beamCMomentum = std::sqrt(beamCEnergy * beamCEnergy - NumberOfNucleonsC * NumberOfNucleonsC * MassProton * MassProton);
fgBeamA.SetPxPyPzE(0, 0, beamAMomentum, beamAEnergy);
Expand Down Expand Up @@ -291,7 +291,7 @@
double mean = calibMeanHist->GetBinContent(binTPCncls, binPin, binEta);
double sigma = calibSigmaHist->GetBinContent(binTPCncls, binPin, binEta);
return (nSigmaValue - mean) / sigma; // Return the calibrated nSigma value
} else if (fgCalibrationType == 2) {

Check failure on line 294 in PWGDQ/Core/VarManager.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number]

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
// get the calibration histograms
CalibObjects calibMean, calibSigma, calibStatus;
switch (species) {
Expand Down Expand Up @@ -458,14 +458,14 @@
// Bimodality coefficient = (skewness^2 + 1) / kurtosis
// return a tuple including the coefficient, mean, RMS, skewness, and kurtosis
size_t n = data.size();
if (n < 3) {

Check failure on line 461 in PWGDQ/Core/VarManager.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number]

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return std::make_tuple(-1.0, -1.0, -1.0, -1.0, -1.0);
}
float mean = std::accumulate(data.begin(), data.end(), 0.0) / n;

float m2 = 0.0, m3 = 0.0, m4 = 0.0;
float diff, diff2;
for (float x : data) {

Check failure on line 468 in PWGDQ/Core/VarManager.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop]

Use constant references for non-modified iterators in range-based for loops.
diff = x - mean;
diff2 = diff * diff;
m2 += diff2;
Expand Down Expand Up @@ -504,7 +504,7 @@
int nBins = static_cast<int>((max - min) / binWidth);
std::vector<int> counts(nBins, 0.0);

for (float x : data) {

Check failure on line 507 in PWGDQ/Core/VarManager.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop]

Use constant references for non-modified iterators in range-based for loops.
if (x < min || x >= max) {
continue; // skip out-of-range values
}
Expand Down
Loading
Loading