Add no_panic feature - #28
Conversation
|
I'm using this crate and producing some wasm file, when this feature is enabled, the size of the wasm file is reduced. |
There was a problem hiding this comment.
Sorry for the massive delay: for some reason I didn't get any notifications from Github for a period. My email is in my Github bio for whatever reason in case I stop getting Github emails: feel free to reach out to me directly there as well.
The general approach looks good, I do have a few changes I'd like to see, specifically to ensure safety invariants are guaranteed (or, in no-panic mode, if they are not).
Security issues have been an issue: when I took over this fork, there was a lot of non-local safety invariants and also some undefined behavior that was fixed. So although everything is sound here, I'd much rather these be very clearly documented, both for source maintainers and for end-users, the panic behaviors.
|
The miri test failures are expected: it seems like there's a miri bug in recent versions of Rust causing rounding errors (this affects main as well). |
2 participants
No description provided.