fix(ci): pin GitHub Actions to commit SHAs (supply chain hardening)#1322
Merged
ErikBjare merged 1 commit intoJun 19, 2026
Merged
Conversation
All 10 external action references were using mutable tags or branches. Pin each third-party action to its current commit SHA with the version in a comment, following the tj-actions/changed-files incident pattern (CVE-2025-30066). Pinned actions: - dtolnay/rust-toolchain@master -> @3c5f7ea (release.yml, 2x) - nick-fields/retry@v4 -> @ad984534 (release.yml, 2x) - softprops/action-gh-release@v3 -> @b4309332 (release.yml) - ActivityWatch/check-version-format-action@v2 -> @5b223bd (release.yml, 2x) - githubocto/repo-visualizer@main -> @a999615 (diagram.yml) - ridedott/merge-me-action@v2 -> @e45e8ab (dependabot-automerge.yml) - vedantmgoyal2009/winget-releaser@v2 -> @4ffc7888 (winget.yml) github/codeql-action (GitHub-maintained) left for a separate pass. Use pinact or Renovate to keep SHAs updated going forward.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All 10 external action references in the CI workflows were using mutable tags or branch names. A tag or branch is a movable pointer — whoever controls the upstream action repository (or anyone who compromises it) can re-point it, and the next workflow run executes the new code with the job's token and any available secrets.
This was flagged by Thibaud Van Den Berghe (thibaud@getplumber.io), who identified the pattern by running the Plumber CLI against the repo. The same attack vector was exploited in CVE-2025-30066 (tj-actions/changed-files), where a moved tag caused CI secrets to be dumped in every consuming repository on the next run.
Changes
Each third-party action is now pinned to its current commit SHA with the human-readable version in a comment:
release.yml(×2)dtolnay/rust-toolchain@master@3c5f7earelease.yml(×2)nick-fields/retry@v4@ad984534release.ymlsoftprops/action-gh-release@v3@b4309332release.yml(×2)ActivityWatch/check-version-format-action@v2@5b223bd(v2.0.1)diagram.ymlgithubocto/repo-visualizer@main@a999615dependabot-automerge.ymlridedott/merge-me-action@v2@e45e8abwinget.ymlvedantmgoyal2009/winget-releaser@v2@4ffc7888The priority targets (
dtolnay/rust-toolchain@masterandsoftprops/action-gh-release@v3) were in the release pipeline and had access to publishing credentials.githubocto/repo-visualizer@mainhadcontents: writeon a moving branch.github/codeql-action(GitHub-maintained) is left for a separate pass — it's lower risk than third-party actions.Keeping SHAs current
To avoid SHA rot, consider adding Renovate or pinact to keep these pinned references updated automatically when upstream releases new versions.