Only async package caching needs prod install#2151
Open
manuelkoester wants to merge 4 commits into
Open
Conversation
Signed-off-by: Manuel Köster <manuelkoestercg@gmail.com>
Signed-off-by: Manuel Köster <manuelkoestercg@gmail.com>
test_add_variants_sync cached versioned-3.0 but never cleaned up, causing the subsequent test_cache_variant to find it already cached and fail with VARIANT_FOUND instead of VARIANT_CREATED. Signed-off-by: Manuel Köster <manuelkoestercg@gmail.com>
manuelkoester
force-pushed
the
bugfix/only_async_package_cache_needs_prod_install
branch
from
July 9, 2026 20:17
c5fdc5c to
e94cb6c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2151 +/- ##
==========================================
+ Coverage 61.32% 61.42% +0.09%
==========================================
Files 164 164
Lines 20568 20568
Branches 3575 3575
==========================================
+ Hits 12613 12633 +20
+ Misses 7084 7067 -17
+ Partials 871 868 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
I've reviewed this and found no substantive issues with the logic and exposed bits and bobs. I'm approving this and put it into the "Next" release milestone. @manuelkoester I'm not bothered by the one-liner coverage gap because the value of the fix supercedes the coverage stat, but if you want to find an easy way to cover it, I wouldn't complain. |
maxnbk
approved these changes
Jul 17, 2026
Signed-off-by: Manuel Köster <manuelkoestercg@gmail.com>
Author
|
Cheers for the review! Added the ~same tests for the other line 🫡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
Basically the same as #2136, but does the same check in another needed location & adds some tests!
Ref #1500
Cheers,
Manuel