Skip to content

fix: Control dependency incompleteness #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
webbrain-one wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Control dependency incompleteness #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/ControlDependencyGraph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ bool pdg::ControlDependencyGraph::runOnFunction(Function &F)
return false;
}

void pdg::ControlDependencyGraph::addControlDepFromNodeToBB(Node &n, BasicBlock &BB, EdgeType edge_type)
void pdg::ControlDependencyGraph::addControlDepFromNodeToBB(Node &n, BasicBlock &BB, EdgeType edge_type, bool is_true = false)
{
ProgramGraph &g = ProgramGraph::getInstance();
for (auto &inst : BB)
{
Node* inst_node = g.getNode(inst);
// TODO: a special case when gep is used as a operand in load. Fix later
if (inst_node != nullptr)
n.addNeighbor(*inst_node, edge_type);
n.addNeighbor(*inst_node, edge_type, is_true);
// assert(inst_node != nullptr && "cannot find node for inst\n");
}
}
Expand Down Expand Up @@ -50,19 +50,17 @@ void pdg::ControlDependencyGraph::addControlDepFromDominatedBlockToDominator(Fun
{
if (!bi->isConditional() || !bi->getCondition())
break;
// Node *cond_node = g.getNode(*bi->getCondition());
// if (!cond_node)
// break;
bool is_true = (succ_bb == bi->getSuccessor(0));
Node *branch_node = g.getNode(*bi);
if (branch_node == nullptr)
break;
BasicBlock *nearestCommonDominator = _PDT->findNearestCommonDominator(&BB, succ_bb);
if (nearestCommonDominator == &BB)
addControlDepFromNodeToBB(*branch_node, *succ_bb, EdgeType::CONTROLDEP_BR);
addControlDepFromNodeToBB(*branch_node, *succ_bb, EdgeType::CONTROLDEP_BR, is_true);

for (auto *cur = _PDT->getNode(&*succ_bb); cur != _PDT->getNode(nearestCommonDominator); cur = cur->getIDom())
{
addControlDepFromNodeToBB(*branch_node, *cur->getBlock(), EdgeType::CONTROLDEP_BR);
addControlDepFromNodeToBB(*branch_node, *cur->getBlock(), EdgeType::CONTROLDEP_BR, is_true);
}
}
}
Expand Down