Update protos for old test vectors and re-generate them.#155
Conversation
jwcullen
commented
Feb 27, 2026
jwcullen
commented
- Old protos are stale and incompatible with comparison scripts.
- Update them, but the modern encoder loudness measurements vary. To keep metadata in sync also update the output files.
- Based on AOMediaCodec/iamf-tools@5beb827.
- Old protos are stale and incompatible with comparison scripts. - Update them, but the modern encoder loudness measurements vary. To keep metadata in sync also update the output files. - Based on AOMediaCodec/iamf-tools@5beb827.
|
These are just needed so the older test vectors can be used on the main branch. @yilun-zhangs |
|
@jwcullen The test vectors have been updated, Should the corresponding test files also be updated? |
|
@jingbo-marquis, we changed how the metadata works to describe these for the v2 test vectors. Most of the changes here are just to sync the metadata, but the resultant test files are the same. A few have changed because they have different loudness measurements due to tweaks or bug-fixes. |
Yes, the loudness values for many test vectors have changed. To maintain consistency, the test files should also be updated. |
|
The GitHub UI is glitchy because there are too many files being changed. But when I check locally the actual test files are updated within this PR. |
Thanks for the clarification! The UI threw me off for a moment. |
3 participants
