Skip to content

Rename React Native npm package#57

Merged
taylanpince merged 1 commit into
masterfrom
rename-react-native-package
Jul 15, 2026
Merged

Rename React Native npm package#57
taylanpince merged 1 commit into
masterfrom
rename-react-native-package

Conversation

@tolgahan-arikan

Copy link
Copy Markdown
Collaborator

Summary

  • rename the npm package from @0xsequence/oms-react-native-sdk to @polygonlabs/oms-wallet-react-native
  • update workspace dependencies, imports, install guidance, package-aware errors, autolinking verification, and release documentation
  • align the standalone Expo manifest with the new package while retaining its last-published registry lock until the post-publish update can resolve 0.2.0

The previous package name remains only in the historical alpha changelog entry and the standalone Expo registry lock. After publication, yarn expo-example:install:published replaces the latter with the new registry package.

Validation

  • confirmed @polygonlabs/oms-wallet-react-native is currently unused on npm
  • yarn verify (23 tests; generated API reference current)
  • yarn expo-example:install
  • npm --prefix examples/expo-example run typecheck
  • yarn expo-example:verify-autolinking (Android and iOS)
  • yarn npm publish --dry-run --access public

@tolgahan-arikan
tolgahan-arikan requested a review from a team July 15, 2026 16:44
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown

Claude finished @tolgahan-arikan's task —— View job


Review — PR #57: Rename React Native npm package

  • Read changed files and verify rename consistency
  • Grep for stray old package references
  • Verify Expo example dependency policy adherence
  • Post review

The rename is clean and consistent across package.json, tsconfig.json, src/client.ts, docs, scripts, and all three examples. The user-facing unsupported() error string in src/client.ts:39 correctly uses the new name. Native layers (Kotlin/Swift/podspec) don't reference the JS package name, so no bridge changes are needed — correct.

Only expected old references remain: the historical CHANGELOG.md:76 alpha entry and the Expo registry lock (examples/expo-example/package-lock.json). Good.

Blocker

examples/expo-example/package.json:15 pins an unpublished version.

"@polygonlabs/oms-wallet-react-native": "0.2.0",

This contradicts the PR's own stated policy ("retain the last-published registry lock until the post-publish update can resolve 0.2.0") and the repo rule "update Expo example deps only after the npm version is published." @polygonlabs/oms-wallet-react-native@0.2.0 isn't on npm yet.

The mismatch is real, not cosmetic: package-lock.json still references the old package @0xsequence/oms-react-native-sdk@0.1.0-alpha.4, so npm ci (used by yarn expo-example:install / the --published path in scripts/install-expo-example-dependencies.sh:12) will fail on the lock↔manifest mismatch until publish. The lockfile and manifest must stay in sync.

Suggested fix — keep the manifest on the last-published spec (old name + 0.1.0-alpha.4, matching the still-locked entry) until 0.2.0 is published, then let yarn expo-example:install:published rewrite both together. Otherwise this branch leaves the standalone Expo example in an uninstallable state.

(The PR body claims yarn expo-example:install was validated — worth confirming, since the current lock/manifest pairing shouldn't pass npm ci.)

Nits

  • examples/expo-example/package.json:2name is still oms-client-react-native-sdk-expo-example (references the pre-pre-rename name). Not blocking, but stale.
  • The alpha 0.1.0 history now lives under a 0.2.0 package name — expected and fine; just noting the changelog's 0.1.0-alpha.* entries predate both renames.

Not evaluated

Auth/session/wallet-selection/signing/transaction security and API.md accuracy — this PR is a pure rename with no API-surface or logic changes, so nothing to review there. API.md was not in the changed-file set, which is correct since exports are unchanged.
rename-react-native-package

@taylanpince
taylanpince merged commit df51dff into master Jul 15, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants