* WIP: migrate repl module and Repl tab to Conductor (#786) Bundle side (src/bundles/repl) was already done in a prior interrupted session: index.ts/protocol.ts/rich_display.ts/stringify_value.ts implement the Conductor BaseModulePlugin, channel protocol, rich-text formatting and value stringification. This commit adds the missing host-side piece: the Repl tab (src/tabs/Repl) was still the legacy pre-Conductor implementation referencing the now-deleted programmable_repl.ts, so it has been rewritten as a Conductor IPlugin that subscribes to the repl channel, replays/relays output and program-text messages, and drives the AceEditor UI. Still to do: run lint/tsc/test for both packages and fix any fallout, then review the diff end-to-end (including a leftover unused REPL_RUNNER_ID export in protocol.ts). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PyGDAXkee7m9yRQSfHhVyZ * Fix lint/tsc/test fallout in repl module and Repl tab (#786) Bundle: - Remove dead REPL_RUNNER_ID export (unused anywhere, unlike the RUNNER_ID/WEB_ID pattern in matrix/sound's protocol.ts). - Fix a genuine unnecessary-assertion lint error and import ordering. - Add unit tests for the pure logic (rich_display.ts, stringify_value.ts). A test for ReplModulePlugin's decorated index.ts itself is not possible: vitest's esbuild-based SSR transform only lowers native (TC39 stage-3) decorators via its bundling API, not the single-file transform API it actually uses to load modules, so any file with an `@moduleMethod`- decorated async generator method fails with a raw SyntaxError on import. This is a pre-existing, documented limitation (see midi's conductorAdapters.ts) that already applies to sound/matrix/pix_n_flix - none of them test their decorated index.ts directly either. Tab: - Fix a non-exhaustive switch (explicitly no-op the tab->bundle 'run'/ 'request' message variants instead of a catch-all default) and two eslint-disable comments that turned out to guard against a rule that isn't actually enabled here. - Fix a test race: a localStorage write assertion needs to wait out the 100ms throttle window rather than checking synchronously. Verified tsc, lint, vitest and the real buildtools build pipeline are all green for both packages. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PyGDAXkee7m9yRQSfHhVyZ * Address CodeRabbit review on #865 - rich_display.ts: anchor checkColorStringValidity's regex (was unanchored, letting a crafted clrt#/clrb# tail break out of the style="..." attribute the tab renders via dangerouslySetInnerHTML - a real DOM XSS via rich_repl_display); bound processRichDisplayContent's recursion so a cyclic pair (set_head/set_tail) can't recurse forever. - stringify_value.ts: add a shared total-node budget alongside the existing depth cap - a pair whose head AND tail both cycle back branches at every level, so depth alone still allows up to 2^MAX_DEPTH calls. - index.ts: guard __runCode against two overlapping runs (e.g. a fast double-click on Run) driving the same evaluator closure concurrently. - tabs/Repl/index.tsx: guard localStorage access (throws in some private-browsing/quota-exceeded contexts); unsubscribe from the channel in destroy() so a discarded plugin instance stops reacting to messages; move fontSize application into an effect keyed on state.fontSize instead of only the AceEditor ref callback, and add a getOutputs() accessor for tests. - Tests: add regression coverage for all of the above, strengthen two tests that weren't actually asserting what their names claimed, and switch two throttle-wait tests to fake timers instead of real 150ms sleeps. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PyGDAXkee7m9yRQSfHhVyZ * Address findings from my own review on #865 - index.ts: set_background_image/set_font_size/set_program_text now call __loadReplTab(), matching __displayOutput's behavior. Previously, a program whose only interaction with the module was one of these three - most plausibly set_program_text, used to pre-populate starter code for a student - would never cause the Repl tab to actually open, silently defeating the feature. - tabs/Repl/index.tsx: apply font size in px, not pt, to actually match set_font_size's own doc comment and parameter name (font_size_px) - pre-existing mismatch carried over from the deleted pre-Conductor tab. No corresponding bundle-side test: importing index.ts directly in a test still hits the same vitest/decorator limitation noted elsewhere in this PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PyGDAXkee7m9yRQSfHhVyZ --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

Uh oh!

Conductor Migration: REPL Module #786

Description

Feature

Checklist

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions