Fix easter_date() beyond the year 3000 on Windows

mktime() on Windows only goes up to the year 3000 and returns -1 beyond
that, so easter_date() returned -1 instead of throwing for the years
3001 to 2000000000. Limit the year to 3000 on Windows.

Author: marc-mabe

NEWS

@@ -2,6 +2,10 @@ PHP                                                                        NEWS
 |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 ?? ??? ????, PHP 8.4.27
 
+- Calendar:
+  . Fixed bug GH-23915 (easter_date() reports inconsistent year ranges and
+    returns -1 after the year 3000 on Windows). (Marc Bennewitz)
+
 - CLI
   . Fix GH-22567 (Windows ZTS CLI SAPI should refresh its TSRMLS cache during
     request activation). (matyhtf)

ext/calendar/easter.c

@@ -40,8 +40,13 @@ static void _cal_easter(INTERNAL_FUNCTION_PARAMETERS, bool gm)
 		/* Timestamps only start after 1970 and are calculated by mktime() */
 		min_year = 1970;
 #ifdef ZEND_ENABLE_ZVAL_LONG64
+# ifdef PHP_WIN32
+		/* mktime() on Windows only goes up to the year 3000 */
+		max_year = 3000;
+# else
 		/* Timestamps only go up to the year 2.000.000.000 */
 		max_year = 2000000000;
+# endif
 #else
 		max_year = 2037;
 #endif

ext/calendar/tests/easter_date_64bit.phpt

@@ -23,11 +23,11 @@ try {
     echo "{$ex->getMessage()}\n";
 }
 ?>
---EXPECT--
+--EXPECTF--
 2000-04-23
 2001-04-15
 2002-03-31
 2045-04-09
 2046-03-25
 2047-04-14
-easter_date(): Argument #1 ($year) must be between 1970 and 2000000000
+easter_date(): Argument #1 ($year) must be between 1970 and %d

ext/calendar/tests/easter_date_checks_upper_bound_64bit.phpt

@@ -1,7 +1,10 @@
 --TEST--
 Test easter_date() on 64bit systems checks the upper year limit
 --SKIPIF--
-<?php if (PHP_INT_SIZE != 8) die("skip 64-bit only"); ?>
+<?php
+if (PHP_INT_SIZE != 8) die("skip 64-bit only");
+if (PHP_OS_FAMILY === "Windows") die("skip not for Windows, see gh23915_windows.phpt");
+?>
 --INI--
 date.timezone=UTC
 --ENV--

ext/calendar/tests/gh23915_windows.phpt

@@ -0,0 +1,29 @@
+--TEST--
+GH-23915 (easter_date() reports inconsistent year ranges in errors and returns -1 for years after 3000 on Windows)
+--SKIPIF--
+<?php
+if (PHP_INT_SIZE != 8) die("skip 64-bit only");
+if (PHP_OS_FAMILY !== "Windows") die("skip Windows only");
+?>
+--INI--
+date.timezone=UTC
+--ENV--
+TZ=UTC
+--EXTENSIONS--
+calendar
+--FILE--
+<?php
+putenv('TZ=UTC');
+// mktime() on Windows only goes up to the year 3000
+foreach ([3000, 3001, 293274701009] as $year) {
+    try {
+        echo date('Y-m-d', easter_date($year)), "\n";
+    } catch (ValueError $ex) {
+        echo "{$ex->getMessage()}\n";
+    }
+}
+?>
+--EXPECT--
+3000-04-13
+easter_date(): Argument #1 ($year) must be between 1970 and 3000
+easter_date(): Argument #1 ($year) must be between 1970 and 3000