The saved pictures pf DCVC-FM have obvious color differences.

[QIN921]

I try to save the decoded frame of DCVC-FM of run_one_point_fast, so I add the code below:
recon_writer = PNGWriter(args['bin_folder'], args['src_width'], args['src_height'])
and

if save_decoded_frame:
                yuv_rec = x_hat.squeeze(0).cpu().numpy()
                rgb = ycbcr444_to_rgb(yuv_rec[:1, :, :], yuv_rec[1:, :, :])
                recon_writer.write_one_frame(rgb=rgb, src_format='rgb')

The metrics of saved json is as the paper report, but the result have obvious color differences and a 8dB PSNR drop.

[yaohualibin]

Are you encoding RGB or YUV? If RGB, are you using the same conversion matrix from YUV to RGB and RGB to YUV?

[QIN921]

The input are YUV videos, and i am trying to save RGB png

[yaohualibin]

Does saving as YUV work as expected?

[QIN921]

Yes, saving as YUV work as expected.

[yaohualibin]

Then I suspect different conversion methods were used to convert YUV to RGB.

[ichlubna]

For anyone interested. Added to test_helper.py:

def save_yuv444(yuv, filepath):
    y = yuv[0]
    u = yuv[1]
    v = yuv[2]

    y = y * 255.0
    u = (u - 0.5) * 255.0 + 128.0
    v = (v - 0.5) * 255.0 + 128.0

    y = np.clip(y, 0, 255).astype(np.uint8)
    u = np.clip(u, 0, 255).astype(np.uint8)
    v = np.clip(v, 0, 255).astype(np.uint8)

    with open(filepath, "wb") as f:
        y.tofile(f)
        u.tofile(f)
        v.tofile(f)

then using as

yuv_rec = x_hat.squeeze(0).cpu().numpy()
save_yuv444(yuv_rec,os.path.join(args['bin_folder'], "recon.yuv"))

and then decoding to png as

ffmpeg -f rawvideo -pix_fmt yuv444p -color_range pc -colorspace bt709 -color_trc bt709 -color_primaries bt709 -video_size 420x560 -i recon.yuv frame_%04d.png

Seem to work well.