Repository navigation
chore(release): bump release workflow Bun to 1.4.4 (CVE-2026-111497) - #3471
Conversation
|
@motsc is attempting to deploy a commit to the HyperDX Team on Vercel. A member of the Team first needs to authorize it. |
|
PR Review
1 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 1 minor None could be anchored to changed lines; they are listed below. Findings outside the changed lines1 minor
Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
[Medium impact] The update affects binaries produced by the CLI release workflow. The PR appears safe to merge, with a non-blocking Bun version mismatch to clean up.
|
| uses: oven-sh/setup-bun@v2 | ||
| with: | ||
| bun-version: '1.3.11' | ||
| bun-version: '1.4.4' |
There was a problem hiding this comment.
The release now builds with Bun 1.4.4, but packages/cli/package.json still declares an exact engines.bun requirement of 1.3.11. Contributors following that requirement use a different compiler from releases, making release-only problems harder to reproduce. Update the declared Bun version alongside this pin so local builds and releases use the same version.
Deep Review✅ No critical issues found. This is a single-line security pin bump ( 🔵 P3 nitpicks (1)
Reviewers (5): correctness, reliability, maintainability, project-standards, previous-comments. Testing gaps: No check asserts the workflow No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
Summary
Bumps the release workflow's Bun pin to 1.4.4, the release carrying a patched Brotli decoder for CVE-2026-111497 / Node2Shell (Broccoli2Shell).
Bun bundles its own copy of the google/brotli C decoder affected by this CVE (an out-of-bounds write reachable when decompressing attacker-controlled Brotli data, rated 9.2 Critical). Bun 1.4.4 is the fixed release. The
bun-versioninput in this workflow determines which Bun builds and ships release artifacts, so this pin decides whether released binaries embed the vulnerable decoder.This closes the last unfixed Bun pin in the repo — the Dockerfiles and CI images were already remediated in #3456 (node 22.23.4 + bun 1.4.4 where applicable).
Changes
.github/workflows/release.yml:bun-version: '1.3.11'→'1.4.4'References
0ed4268(released as 1.2.1)