Please tag releases that would match haproxy branches/releases

[darix]

it seems blindly updating the code from this repository can get you into a non working state.

[   10s] /home/abuild/rpmbuild/BUILD/haproxy-3.4.1+git0.3e888a769-build/haproxy-3.4.1+git0.3e888a769/haproxy-opentelemetry-6344dfa/src/cli.c: In function ‘flt_otel_cli_parse_status’:
[   10s] /home/abuild/rpmbuild/BUILD/haproxy-3.4.1+git0.3e888a769-build/haproxy-3.4.1+git0.3e888a769/haproxy-opentelemetry-6344dfa/src/cli.c:359:43: error: storage size of ‘status’ isn’t known
[   10s]   359 |         struct otelc_pipeline_status      status;
[   10s]       |                                           ^~~~~~
[   10s] /home/abuild/rpmbuild/BUILD/haproxy-3.4.1+git0.3e888a769-build/haproxy-3.4.1+git0.3e888a769/haproxy-opentelemetry-6344dfa/src/cli.c:375:9: error: implicit declaration of function ‘otelc_pipeline_status_get’ [-Wimplicit-function-declaration]
[   10s]   375 |         otelc_pipeline_status_get(&status);
[   10s]       |         ^~~~~~~~~~~~~~~~~~~~~~~~~
[   10s] /home/abuild/rpmbuild/BUILD/haproxy-3.4.1+git0.3e888a769-build/haproxy-3.4.1+git0.3e888a769/haproxy-opentelemetry-6344dfa/src/cli.c:381:54: error: invalid use of undefined type ‘const struct otelc_export_status’
[   10s]   381 |                 int64_t                  age = sig[i]->last_export_ms;
[   10s]       |                                                      ^~
[   10s] /home/abuild/rpmbuild/BUILD/haproxy-3.4.1+git0.3e888a769-build/haproxy-3.4.1+git0.3e888a769/haproxy-opentelemetry-6344dfa/src/cli.c:391:94: error: invalid use of undefined type ‘const struct otelc_export_status’
[   10s]   391 |                         (void)snprintf(queued, sizeof(queued), "%" PRId64 "/%" PRId64, sig[i]->queue_depth, sig[i]->queue_capacity);
[   10s]       |                                                                                              ^~
[   10s] /home/abuild/rpmbuild/BUILD/haproxy-3.4.1+git0.3e888a769-build/haproxy-3.4.1+git0.3e888a769/haproxy-opentelemetry-6344dfa/src/cli.c:391:115: error: invalid use of undefined type ‘const struct otelc_export_status’
[   10s]   391 |                         (void)snprintf(queued, sizeof(queued), "%" PRId64 "/%" PRId64, sig[i]->queue_depth, sig[i]->queue_capacity);
[   10s]       |                                                                                                                   ^~
[   10s] /home/abuild/rpmbuild/BUILD/haproxy-3.4.1+git0.3e888a769-build/haproxy-3.4.1+git0.3e888a769/haproxy-opentelemetry-6344dfa/src/cli.c:392:84: error: invalid use of undefined type ‘const struct otelc_export_status’
[   10s]   392 |                         (void)snprintf(dropped, sizeof(dropped), "%" PRId64, sig[i]->dropped);
[   10s]       |                                                                                    ^~
[   10s] /home/abuild/rpmbuild/BUILD/haproxy-3.4.1+git0.3e888a769-build/haproxy-3.4.1+git0.3e888a769/haproxy-opentelemetry-6344dfa/src/cli.c:402:142: error: invalid use of undefined type ‘const struct otelc_export_status’
[   10s]   402 |                 (void)memprintf(&msg, "%s     %-7s  %-13s  %11s  %11" PRId64 "  %11" PRId64 "  %s\n", msg, signal[i], queued, dropped, sig[i]->export_ok, sig[i]->export_fail, last);
[   10s]       |                                                                                                                                              ^~
[   10s] /home/abuild/rpmbuild/BUILD/haproxy-3.4.1+git0.3e888a769-build/haproxy-3.4.1+git0.3e888a769/haproxy-opentelemetry-6344dfa/src/cli.c:402:161: error: invalid use of undefined type ‘const struct otelc_export_status’
[   10s]   402 |                 (void)memprintf(&msg, "%s     %-7s  %-13s  %11s  %11" PRId64 "  %11" PRId64 "  %s\n", msg, signal[i], queued, dropped, sig[i]->export_ok, sig[i]->export_fail, last);
[   10s]       |                                                                                                                                                                 ^~
[   10s] /home/abuild/rpmbuild/BUILD/haproxy-3.4.1+git0.3e888a769-build/haproxy-3.4.1+git0.3e888a769/haproxy-opentelemetry-6344dfa/src/cli.c:359:43: warning: unused variable ‘status’ [-Wunused-variable]
[   10s]   359 |         struct otelc_pipeline_status      status;
[   10s]       |                                           ^~~~~~

having releases would help packagers to package stable things.

[zaga00]

The filter is compatible with any current version of haproxy, the problem here is that you need to use the latest version of the opentelemetry c wrapper. I haven't done any tags or releases because I add commits too often and because the filter is still in experimental status.

[darix]

you could add a pkgconfig check to enforce the latest version to make it more obvious that "hey your other package is too old"

also you can have as many releases per day if you want. version numbers are free. i can even find you the code to automate the tag to release stuff, if you want.

[zaga00]

Nothing is free if I have to spend time on it that I could otherwise use to do something useful. :)

However, as things are getting closer to the end of development and the beginning of maintenance, next week I will start tagging versions for this repository. For now, it's always a good idea to also check out the opentelemetry c wrapper repository when using this repository.

Thank you for your helpful and constructive feedback.

[darix]

Oh I know that feeling. That's why e.g. helped Holger to do this for eturnal:

https://github.com/processone/eturnal/blob/master/.github/workflows/release.yml

I automate most of my stuff so I can focus on other stuff :)