Repository navigation
[bot] Merge master/6848b82f into rel/dev - #1835
Conversation
The backend permission hierarchy now includes CREATE_VISUALIZATION
(implied by ANALYZE) and CREATE_COMPUTED_ATTRIBUTE (implied by MANAGE),
but the specs this client generates from predate both. Because the
values are implied, the workspace meta permissions of every ANALYZE or
MANAGE user contain them, so reading a workspace failed client-side
validation even when nobody was granted either permission explicitly.
Declarative permissions and permission assignments that contain them
could not be read, and a grant using them could not be built.
Adds both values to the seven workspace-permission enums in the
metadata spec, in backend order, and switches the security info of
POST /entities/workspaces/{id}/visualizationObjects to
CREATE_VISUALIZATION, then regenerates. The computed-attributes endpoint
guarded by CREATE_COMPUTED_ATTRIBUTE is not in the specs yet and is
left for a full re-download, so this delta stays limited to the enums.
jira: F1-2924
risk: low
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
feat(gooddata-api-client): add missing workspace permissions
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1835 +/- ##
========================================
Coverage 83.19% 83.19%
========================================
Files 330 330
Lines 21931 21931
========================================
Hits 18246 18246
Misses 3685 3685 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
🚀 Automated PR to perform merge from master into rel/dev with changes up to 6848b82 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/36567297404).