feat(gooddata-api-client): add missing workspace permissions - #1834
Merged
Merged
Conversation
The backend permission hierarchy now includes CREATE_VISUALIZATION
(implied by ANALYZE) and CREATE_COMPUTED_ATTRIBUTE (implied by MANAGE),
but the specs this client generates from predate both. Because the
values are implied, the workspace meta permissions of every ANALYZE or
MANAGE user contain them, so reading a workspace failed client-side
validation even when nobody was granted either permission explicitly.
Declarative permissions and permission assignments that contain them
could not be read, and a grant using them could not be built.
Adds both values to the seven workspace-permission enums in the
metadata spec, in backend order, and switches the security info of
POST /entities/workspaces/{id}/visualizationObjects to
CREATE_VISUALIZATION, then regenerates. The computed-attributes endpoint
guarded by CREATE_COMPUTED_ATTRIBUTE is not in the specs yet and is
left for a full re-download, so this delta stays limited to the enums.
jira: F1-2924
risk: low
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
jeskepetr
enabled auto-merge
September 29, 2026 11:38
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1834 +/- ##
=======================================
Coverage 83.19% 83.19%
=======================================
Files 330 330
Lines 21931 21931
=======================================
Hits 18246 18246
Misses 3685 3685 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Vojtasii
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes F1-2924.
CREATE_VISUALIZATION(implied byANALYZE) andCREATE_COMPUTED_ATTRIBUTE(implied byMANAGE) exist in the backend permission hierarchy but were missing from the workspace-permission enums in the generated client. Because both are implied, the workspace metapermissionsof every ANALYZE/MANAGE user contains them, so reading a workspace failed deserialization. Declarative permissions and permission assignments containing them could not be read either, and a grant using them could not be built.Same approach as the
CREATE_METRICchange (1c1ae20):schemas/gooddata-metadata-client.json: both values added to the seven workspace-permission enums in backend order (… CREATE_METRIC, CREATE_VISUALIZATION, CREATE_COMPUTED_ATTRIBUTE, VIEW), and thex-gdc-security-infoofPOST /entities/workspaces/{id}/visualizationObjectsswitched fromANALYZEtoCREATE_VISUALIZATION.make api-client-local— the mergedschemas/gooddata-api-client.jsonand five model files.No
gooddata-sdkchange is needed; it passes permission strings through. The computed-attributes endpoint guarded byCREATE_COMPUTED_ATTRIBUTEis not in the specs yet and is left for a full re-download. I checked every other permission enum (organization, data source, dashboard/object, user, user group) againstgdc-nasmaster, and they all match.Test plan
JsonApiWorkspaceOutMeta,DeclarativeSingleWorkspacePermission,DeclarativeWorkspaceHierarchyPermissionandWorkspacePermissionAssignmentwith the new values succeedsmake -C packages/gooddata-sdk format lint type-checkTEST_ENVS=py314 make -C packages/gooddata-sdk test— 572 passed, 2 skipped, 3 xfailedRisk
low— additive enum values in the generated client; no request shapes change.🤖 Generated with Claude Code