From 12ba064ca475356aa5cb7d5e0598d15988e08c12 Mon Sep 17 00:00:00 2001 From: GabrielBBaldez <130607246+GabrielBBaldez@users.noreply.github.com> Date: Tue, 9 Jun 2026 08:51:05 -0300 Subject: [PATCH] feat!: add projectDescription to AI prompt completions and remove assistActionAiPromptId Add projectDescription to the AI prompt completion resource, and remove the assistActionAiPromptId field from AiSetting now that the assist AI prompt action is gone. BREAKING CHANGE: AiSetting.assistActionAiPromptId is removed. Closes #376 --- .../crowdin/client/ai/model/AiPromptCompletionRequest.java | 1 + src/main/java/com/crowdin/client/ai/model/AiSetting.java | 1 - src/test/java/com/crowdin/client/ai/AIApiTest.java | 5 ++--- src/test/resources/api/ai/editAiSettingRequest.json | 2 +- src/test/resources/api/ai/getAiSettingResponse.json | 1 - src/test/resources/api/ai/promptCompletionRequest.json | 3 ++- 6 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/main/java/com/crowdin/client/ai/model/AiPromptCompletionRequest.java b/src/main/java/com/crowdin/client/ai/model/AiPromptCompletionRequest.java index 9761095e7..cf6cb8fe7 100644 --- a/src/main/java/com/crowdin/client/ai/model/AiPromptCompletionRequest.java +++ b/src/main/java/com/crowdin/client/ai/model/AiPromptCompletionRequest.java @@ -20,5 +20,6 @@ public static class AiPromptResource { private List filteredStringsIds; private Map overridePromptValues; private String customInstruction; + private String projectDescription; } } diff --git a/src/main/java/com/crowdin/client/ai/model/AiSetting.java b/src/main/java/com/crowdin/client/ai/model/AiSetting.java index 10d421afb..3d526b379 100644 --- a/src/main/java/com/crowdin/client/ai/model/AiSetting.java +++ b/src/main/java/com/crowdin/client/ai/model/AiSetting.java @@ -7,7 +7,6 @@ @Data public class AiSetting { - private Long assistActionAiPromptId; private Boolean showSuggestion; private Long editorSuggestionAiPromptId; diff --git a/src/test/java/com/crowdin/client/ai/AIApiTest.java b/src/test/java/com/crowdin/client/ai/AIApiTest.java index 5e591fbe7..b73cbd944 100644 --- a/src/test/java/com/crowdin/client/ai/AIApiTest.java +++ b/src/test/java/com/crowdin/client/ai/AIApiTest.java @@ -330,7 +330,6 @@ public void downloadAiReportTest() { public void getAiSettingTest() { AiSetting aiSetting = this.getAiApi().getAiSetting(userId).getData(); assertNotNull(aiSetting); - assertEquals(aiSetting.getAssistActionAiPromptId(), 2); assertEquals(aiSetting.getEditorSuggestionAiPromptId(), 5); assertEquals(aiSetting.getShortcuts().size(), 1); } @@ -339,11 +338,10 @@ public void getAiSettingTest() { public void editAiSettingTest() { PatchRequest request = new PatchRequest(); request.setOp(PatchOperation.REPLACE); - request.setPath("/assistActionAiPromptId"); + request.setPath("/editorSuggestionAiPromptId"); ResponseObject aiSettingResponseObject = this.getAiApi().editAiSetting(userId, Collections.singletonList(request)); assertNotNull(aiSettingResponseObject.getData()); - assertEquals(aiSettingResponseObject.getData().getAssistActionAiPromptId(), 2); assertEquals(aiSettingResponseObject.getData().getEditorSuggestionAiPromptId(), 5); } @@ -477,6 +475,7 @@ public void generateAiPromptCompletionTest() { AiPromptCompletionRequest aiPromptCompletionRequest = new AiPromptCompletionRequest(); AiPromptCompletionRequest.AiPromptResource aiPromptResource = new AiPromptCompletionRequest.AiPromptResource(); aiPromptResource.setProjectId(123L); + aiPromptResource.setProjectDescription("Mobile app project"); aiPromptCompletionRequest.setResources(aiPromptResource); ResponseObject response = this.getAiApi().generatePromptCompletion(userId, aiPromptId, aiPromptCompletionRequest); assertEquals(response.getData().getIdentifier(), completionId); diff --git a/src/test/resources/api/ai/editAiSettingRequest.json b/src/test/resources/api/ai/editAiSettingRequest.json index 09bf655d5..5b038c3c1 100644 --- a/src/test/resources/api/ai/editAiSettingRequest.json +++ b/src/test/resources/api/ai/editAiSettingRequest.json @@ -1,6 +1,6 @@ [ { "op": "replace", - "path": "/assistActionAiPromptId" + "path": "/editorSuggestionAiPromptId" } ] diff --git a/src/test/resources/api/ai/getAiSettingResponse.json b/src/test/resources/api/ai/getAiSettingResponse.json index 4b911e8c7..e54f32e8e 100644 --- a/src/test/resources/api/ai/getAiSettingResponse.json +++ b/src/test/resources/api/ai/getAiSettingResponse.json @@ -1,6 +1,5 @@ { "data": { - "assistActionAiPromptId": 2, "editorSuggestionAiPromptId": 5, "shortcuts": [ { diff --git a/src/test/resources/api/ai/promptCompletionRequest.json b/src/test/resources/api/ai/promptCompletionRequest.json index 02b435441..8bacc58d0 100644 --- a/src/test/resources/api/ai/promptCompletionRequest.json +++ b/src/test/resources/api/ai/promptCompletionRequest.json @@ -1,5 +1,6 @@ { "resources": { - "projectId": 123 + "projectId": 123, + "projectDescription": "Mobile app project" } } \ No newline at end of file