Fix #14850 (Compilation fails on oraclelinux:8 (g++ 8.5.0 released in 2021))

Author: danmar

.github/workflows/CI-unixish-docker.yml

@@ -63,6 +63,12 @@ jobs:
         run: |
           apk add cmake make g++ pcre-dev
 
+      - name: Install missing software on Oracle Linux
+        if: contains(matrix.image, 'oraclelinux')
+        run: |
+          yum install -y git python3 which epel-release
+          yum install -y cmake3 gcc-c++ make pcre-devel
+
       # needs to be called after the package installation since
       # - it doesn't call "apt-get update"
       - name: ccache
@@ -87,7 +93,7 @@ jobs:
 
     strategy:
       matrix:
-        image: ["ubuntu:24.04", "ubuntu:25.10", "alpine:3.23"]
+        image: ["ubuntu:24.04", "ubuntu:25.10", "alpine:3.23", "oraclelinux:8"]
       fail-fast: false # Prefer quick result
 
     runs-on: ubuntu-22.04
@@ -111,6 +117,12 @@ jobs:
         run: |
           apk add make g++ pcre-dev bash python3 libxml2-utils
 
+      - name: Install missing software on Oracle Linux
+        if: contains(matrix.image, 'oraclelinux')
+        run: |
+          yum install -y git python3 which epel-release
+          yum install -y cmake3 gcc-c++ make pcre-devel
+
       # needs to be called after the package installation since
       # - it doesn't call "apt-get update"
       - name: ccache
@@ -121,15 +133,29 @@ jobs:
       # /usr/lib/ccache/bin - Alpine Linux
 
       - name: Build cppcheck
+        if: "!contains(matrix.image, 'oraclelinux')"
         run: |
           export PATH="/usr/lib/ccache/bin:/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH"
           make -j$(nproc) HAVE_RULES=yes CXXOPTS="-Werror"
 
+      - name: Build cppcheck (Oracle Linux)
+        if: contains(matrix.image, 'oraclelinux')
+        run: |
+          export PATH="/usr/lib/ccache/bin:/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH"
+          make -j$(nproc) HAVE_RULES=yes CXXOPTS="-Werror" CPPFLAGS="-DGCC_BUG_HACK_NOEXCEPT"
+
       - name: Build test
+        if: "!contains(matrix.image, 'oraclelinux')"
         run: |
           export PATH="/usr/lib/ccache/bin:/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH"
           make -j$(nproc) HAVE_RULES=yes CXXOPTS="-Werror" testrunner
 
+      - name: Build test (Oracle Linux)
+        if: contains(matrix.image, 'oraclelinux')
+        run: |
+          export PATH="/usr/lib/ccache/bin:/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH"
+          make -j$(nproc) HAVE_RULES=yes CXXOPTS="-Werror" CPPFLAGS="-DGCC_BUG_HACK_NOEXCEPT" testrunner
+
       - name: Run test
         run: |
           make -j$(nproc) HAVE_RULES=yes test

lib/settings.cpp

@@ -79,8 +79,8 @@ Settings::~Settings() = default;
 Settings::Settings(const Settings&) = default;
 Settings & Settings::operator=(const Settings &) = default;
 
-Settings::Settings(Settings&&) noexcept = default;
-Settings & Settings::operator=(Settings &&) noexcept = default;
+Settings::Settings(Settings&&) NOEXCEPT = default;
+Settings & Settings::operator=(Settings &&) NOEXCEPT = default;
 
 std::string Settings::loadCppcheckCfg(Settings& settings, Suppressions& suppressions, bool debug)
 {

lib/settings.h

@@ -94,6 +94,13 @@ class SimpleEnableGroup {
 };
 
 
+#ifdef GCC_BUG_HACK_NOEXCEPT
+#define  NOEXCEPT
+#else 
+#define  NOEXCEPT  noexcept
+#endif
+
+
 /**
  * @brief This is just a container for general settings so that we don't need
  * to pass individual values to functions or constructors now or in the
@@ -113,8 +120,8 @@ class CPPCHECKLIB WARN_UNUSED Settings {
     Settings(const Settings&);
     Settings& operator=(const Settings&);
 
-    Settings(Settings&&) noexcept;
-    Settings& operator=(Settings&&) noexcept;
+    Settings(Settings&&) NOEXCEPT;
+    Settings& operator=(Settings&&) NOEXCEPT;
 
     static std::string loadCppcheckCfg(Settings& settings, Suppressions& suppressions, bool debug = false);