Skip to content

[sir_model] update code and text - #1050

Merged
jstac merged 5 commits into
mainfrom
sir_update
Sep 6, 2026
Merged

jstac merged 5 commits into
mainfrom
sir_update

Conversation

@longye-tian

@longye-tian longye-tian commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Hi @jstac

This PR updates the sir_model lecture according to #1049

Best,
Longye

@longye-tian longye-tian self-assigned this Sep 3, 2026
@longye-tian longye-tian added enhancement Improvement to existing material do-not-merge Approved-looking but must not be merged yet (hold / pin) labels Sep 3, 2026
@longye-tian longye-tian linked an issue Sep 3, 2026 that may be closed by this pull request
23 tasks done
@github-actions

github-actions Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

📖 Netlify Preview Ready!

Preview URL: https://pr-1050--sunny-cactus-210e3e.netlify.app

Commit: d458c0b

📚 Changed Lectures


Build Info

@longye-tian
longye-tian marked this pull request as ready for review September 6, 2026 07:10
@longye-tian longye-tian removed the do-not-merge Approved-looking but must not be merged yet (hold / pin) label Sep 6, 2026
@jstac

jstac commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Thanks @longye-tian ! Much appreciated. All changes are good. Merging.

@mmcky

mmcky commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

\translate-resync

Re-running the zh-cn sync of sir_model, whose earlier run translated but failed to open its PR (#1051). The file is unchanged on main since this merge, and the zh-cn translation sits at the pre-PR English, so the resync delivers exactly this change. Tracked in QuantEcon/lecture-python.zh-cn#298.

@mmcky

mmcky commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

✅ Translation sync completed (zh-cn)

Target repo: QuantEcon/lecture-python.zh-cn
Translation PR: QuantEcon/lecture-python.zh-cn#302
Files synced (1):

  • lectures/sir_model.md

mmcky added a commit to QuantEcon/lecture-python.zh-cn that referenced this pull request Oct 22, 2026
The 2026-08-20 quality audit's one major finding on this lecture: the
Chinese said to delay the infection peak until *before* a vaccine is
found, where the source's point is the reverse, that pushing the peak
further into the future may reduce cumulative deaths if a vaccine is
found. QuantEcon/lecture-python.myst#1050 only touched this sentence's
wording ("the peak of the curve"), so the resync kept the existing
translation. Retranslated to follow the source.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mmcky added a commit to QuantEcon/lecture-python.zh-cn that referenced this pull request Oct 22, 2026
* Update translation: lectures/sir_model.md

* Update translation: .translate/state/sir_model.md.yml

* sir_model: correct the inverted closing sentence

The 2026-08-20 quality audit's one major finding on this lecture: the
Chinese said to delay the infection peak until *before* a vaccine is
found, where the source's point is the reverse, that pushing the peak
further into the future may reduce cumulative deaths if a vaccine is
found. QuantEcon/lecture-python.myst#1050 only touched this sentence's
wording ("the peak of the curve"), so the resync kept the existing
translation. Retranslated to follow the source.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* sir_model: drop a figure.figsize line the source does not have

plt.rcParams["figure.figsize"] = (11, 5) sat in the imports cell with
no counterpart in the English, one of eight such lines the 2026-08-20
audit found riding along with the font configuration. Removed, so the
cell's code matches the source apart from the i18n font block.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* sir_model: space before three links and roles

The zh-cn rule (QuantEcon/project-translation#70): a space before an
inline role or link. Three lines in passages this resync did not
change still ran them into the preceding character.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
mmcky added a commit to QuantEcon/lecture-python.zh-cn that referenced this pull request Oct 22, 2026
#302, the sync of QuantEcon/lecture-python.myst#1050, carried every
English change, but it also rewrote passages whose English did not
change. This puts the reviewed text back there (the 2025 review by yuki
and Humphrey Yang, and the March 2025 text they kept) and keeps every
change the English made. Text and plot labels only: structural parity
holds, the 25 code cells match the source with strings masked, and both
math blocks are identical.

- 时间路径: nine reviewed lines, among them 主要关注的是 and its two
  bullets (yuki's), and the partition sentence, whose R is math again.
- 参数: its four reviewed lines, so 阿特克森 is Atkeson again, as in
  the rest of the lecture.
- The state list reads 易感者…移出者 again, as the intro does, with the
  English's new $S$, $E$, $I$, $R$.
- Plot labels are Chinese throughout: 人口比例 on the four y-axes that
  were English (解除封锁 already used it) and 天数 on both x-axes.

Lines that the July forward resync (#151) wrote and #302 reworded keep
#302's text. Both zh-cn rules hold on every prose line
(QuantEcon/project-translation#70).

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement to existing material

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sir_model] Some suggestions on code and wording

3 participants