Skip to content

London | 26-SDC-Mar | Jamal Laqdiem | Sprint 4 | Implement Shell Tools In Python#468

Open
jamallaqdiem wants to merge 6 commits into
CodeYourFuture:mainfrom
jamallaqdiem:implement-shell-tools-python
Open

London | 26-SDC-Mar | Jamal Laqdiem | Sprint 4 | Implement Shell Tools In Python#468
jamallaqdiem wants to merge 6 commits into
CodeYourFuture:mainfrom
jamallaqdiem:implement-shell-tools-python

Conversation

@jamallaqdiem

Copy link
Copy Markdown

Self checklist

  • [x ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [x ] My changes meet the requirements of the task
  • [x ] I have tested my changes
  • [x ] My changes follow the style guide

Changelist

implemented shell tools ls, wc and cat in python.

@jamallaqdiem jamallaqdiem added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🦑 Size Large 4-8 hours 📅 Sprint 4 Assigned during Sprint 4 of this module labels Apr 5, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, but there is some work left to do here.

Is there a package you could use to help with managing arguments? Right now it is a bit complex, and you can't combine single-letter arguments like the command line tools.

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 3, 2026
@jamallaqdiem jamallaqdiem added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 4, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. This task is complete now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 🦑 Size Large 4-8 hours 📅 Sprint 4 Assigned during Sprint 4 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants