Repository navigation
Manchester | 26-ITP-Sept | Fatima Rouchi | Sprint 3 | Coursework/sprint 3 - #1634
fatimarouchi wants to merge 24 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fatimarouchi
added
the
Needs Review
iscmiguelsamaniego
left a comment
iscmiguelsamaniego
left a comment
There was a problem hiding this comment.
"Fantastic work overall across all these exercises! You've shown great progress in fixing scope issues, handling function parameters, working with string methods, and writing robust tests.
As you keep practicing, what strategies do you find most helpful for anticipating edge cases before writing your code?"
fatimarouchi
added
Needs Review
mayowaolokun
added
Review in progress
mayowaolokun
left a comment
mayowaolokun
left a comment
There was a problem hiding this comment.
You have clearly understood the main ideas, and your fixes and edge-case tests show good thinking.
I have left a few comments on things to look at again, mainly output formatting, adding more test examples, and how your tests report success. Please read through them, make your changes.
mayowaolokun
added
Reviewed
fatimarouchi
added
Needs Review
|
Hi,the fixes are consistent with the exercise goals, and the code in the updated files is completing the intended tasks correctly. The explanations and corrected implementations for the key-error/debugging exercises are clear, and the functions for BMI, case conversion, currency formatting, and time formatting all appear to match the requirements. Overall: I approve it from a review perspective. |
4 participants
Self checklist
CYF-1053